[systemd] disable default systemd udev rules for interfaces#7369
Merged
lguohan merged 2 commits intosonic-net:masterfrom Apr 22, 2021
Merged
[systemd] disable default systemd udev rules for interfaces#7369lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
lguohan
reviewed
Apr 19, 2021
lguohan
previously approved these changes
Apr 21, 2021
Collaborator
|
Collaborator
Author
|
Collaborator
|
since /etc/systemd/network override /usr/lib/systemd/network, i think it is better to provide our own policy explicitly. we can provide a file with mac address policy as none and copy to /etc/systemd/network, it would be better since in the future we may want to customize the other policy as well. |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
lguohan
approved these changes
Apr 22, 2021
lguohan
pushed a commit
that referenced
this pull request
May 2, 2021
Fix #7364 99-default.link - was always in SONiC, but previous systemd (<247) had an issue and it did not work due to issue systemd/systemd#3374. Now systemd 247 works. However, such policy overrides teamd provided mac address which causes teamd netdev to use a random mac address. Therefore, needs to be disabled. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
…t#7369) Fix sonic-net#7364 99-default.link - was always in SONiC, but previous systemd (<247) had an issue and it did not work due to issue systemd/systemd#3374. Now systemd 247 works. However, such policy overrides teamd provided mac address which causes teamd netdev to use a random mac address. Therefore, needs to be disabled. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…t#7369) Fix sonic-net#7364 99-default.link - was always in SONiC, but previous systemd (<247) had an issue and it did not work due to issue systemd/systemd#3374. Now systemd 247 works. However, such policy overrides teamd provided mac address which causes teamd netdev to use a random mac address. Therefore, needs to be disabled. Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fix #7364
99-default.link - was always in SONiC, but previous systemd (<247) had an issue and it did not work due to issue systemd/systemd#3374. Now systemd 247 works.
However, such policy overrides teamd provided mac address which causes teamd netdev to use a random mac
address. Therefore, needs to be disabled.
How I did it
Disable default systemd udev rules for interfaces.
How to verify it
Execute #7364 reproduction script.
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)